loke/ng2-fittext
1
0
Fork 0
Code Issues 2 Pull requests 2 Projects Releases 3 Packages Wiki Activity Actions

Fix AOT issue #22

Merged
davidstellini merged 1 commit from patch-1 into master 2019-10-10 19:52:13 +00:00
Conversation 2 Commits 1 Files changed 1 +2 -2
davidstellini commented 2019-10-10 13:25:49 +00:00 (Migrated from github.com)
Copy link

This library breaks when running the production build on Angular 8 using AOT, as per https://stackoverflow.com/questions/48163344/angular-aot-error-in-ng-component-html-file-expected-0-arguments-but-got-1/48172467
This is the error: Ng2FittextDirective, Expected 0 arguments, but got 1.
This MR fixes this issue.

This library breaks when running the production build on Angular 8 using AOT, as per https://stackoverflow.com/questions/48163344/angular-aot-error-in-ng-component-html-file-expected-0-arguments-but-got-1/48172467 This is the error: `Ng2FittextDirective, Expected 0 arguments, but got 1.` This MR fixes this issue.
thisloke commented 2019-10-10 19:52:28 +00:00 (Migrated from github.com)
Copy link

Thanks David!

Thanks David!
davidstellini commented 2019-10-14 06:51:32 +00:00 (Migrated from github.com)
Copy link

@lokenxo Would you be able to republish? Thanks :)

@lokenxo Would you be able to republish? Thanks :)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
dependencies

Pull requests that update a dependency file

  
duplicate

   
enhancement

   
help wanted

   
invalid

   
investigation

Something to investigate before assigning it a proper tag

  
question

   
release

[Utility label] Release

  
spike

   
wontfix
No labels
bug
dependencies
duplicate
enhancement
help wanted
invalid
investigation
question
release
spike
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: loke/ng2-fittext#22
No description provided.
Delete branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?