Refactored code to improve testing and expressiveness #33

Merged
giacomoferlaino merged 2 commits from master into master 2020-03-24 20:46:30 +00:00
giacomoferlaino commented 2020-03-18 01:05:01 +00:00 (Migrated from github.com)

Refactored a minor part of the code to improve unit testing and use more explicit methods.

Refactored checkOverflow method.
Refactored ngAfterViewInit method.

Added hasXAxisOverflow method to determine if the x axis overflow is present.
Added hasYAxisOverflow method to determine if the y axis overflow is present.
Added hasOverflow method to determine if the element has overflow.

Refactored a minor part of the code to improve unit testing and use more explicit methods. Refactored checkOverflow method. Refactored ngAfterViewInit method. Added hasXAxisOverflow method to determine if the x axis overflow is present. Added hasYAxisOverflow method to determine if the y axis overflow is present. Added hasOverflow method to determine if the element has overflow.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: loke/ng2-fittext#33
No description provided.